[LITMUS^RT] RFC control page & test suite fixes

[Björn Brandenburg]

On Jun 26, 2012, at 7:33 PM, Christopher Kenna wrote:

> On Mon, Jun 25, 2012 at 8:58 AM, Björn Brandenburg <bbb at mpi-sws.org> wrote:
>> 
>> For the kernel, I've pushed prop/control-page-fixes, which improves the control page driver (but does not change the existing features).
>> 
>> Please let me know if you have any comments.
> 
> One question: Is __S011 more consistent across architectures (and
> maybe PAGE_SHARED is not)? I thought they were equivalent but did not
> dig deeply into the source for all architectures.

Good point, I wasn't sure about this. A quick search reveals that PAGE_SHARED is defined by most (all?) architectures, but that it is not used in architecture-indepdendent code (couldn't find it anywhere in include/, kernel/, mm/, net/, ipc/, or fs/). In contrast, __S011 is used in mm/mmap.c, so it has to be defined by all architectures. So I went with __S011.

Do you know of a place that documents which constants the VM subsystem expects to be defined by each architecture?

> 
> Also, your umlaut caused arch/x86/include/asm/feather_trace_32.h and
> arch/x86/include/asm/feather_trace_64.h to flip to UTF-8 now. This is
> probably not an issue though, correct?

Ooops. I think it should be ok since it's only in a comment. If it causes problem, let me know and I'll revert it.

- Björn